Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds optional parameter for custom url to swagger-ui css and js bundle #63

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

BeGj
Copy link

@BeGj BeGj commented Nov 7, 2023

Solves #62

@@ -36,9 +37,6 @@ export const swagger =
const schema = {}
let totalRoutes = 0

if (!version)
version = `https://unpkg.com/swagger-ui-dist@${version}/swagger-ui.css`
Copy link
Author

@BeGj BeGj Nov 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed nonsense code..?

@BeGj
Copy link
Author

BeGj commented Nov 7, 2023

Merge request is ready for inspection/approval.

@BeGj BeGj changed the title Added parameter for custom swagger-ui css and js bundle urls Adds optional parameter for custom url to swagger-ui css and js bundle Nov 8, 2023
@BeGj
Copy link
Author

BeGj commented Dec 6, 2023

Anyone?

@marclave marclave self-requested a review March 20, 2024 15:23
@marclave
Copy link
Collaborator

hi @BeGj this is a great idea! the package has changed slightly but would love to add custom urls to point to for @scalar and swagger-ui :)

if you rebase + resolve the conflicts, might be easier to make a new branch off of latest main :)

I can review once it's updated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants