Skip to content

Commit

Permalink
Merge pull request #552 from aleclarson/fix/promisegroup-shift
Browse files Browse the repository at this point in the history
fix: shift promise in `PromiseGroup` even when rejected
  • Loading branch information
SaltyAom committed Mar 25, 2024
2 parents 433a224 + 5eed3ba commit 30d014b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/utils.ts
Expand Up @@ -858,10 +858,10 @@ export class PromiseGroup implements PromiseLike<void> {
while (this.promises.length > 0) {
try {
await this.promises[0]
this.promises.shift()
} catch (error) {
this.onError(error)
}
this.promises.shift()
}
this.root = null
}
Expand Down

0 comments on commit 30d014b

Please sign in to comment.