fix: support volar 1.0 #3787
Merged
fix: support volar 1.0 #3787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Can you add changelog entry? That will break the config of those using the old server right? |
jadestrong
force-pushed
the
feat/lsp-volar
branch
from
28bbd52
to
a17cf8e
Compare
|
Can you resolve the conflicts? Then it is good to go |
jadestrong
force-pushed
the
feat/lsp-volar
branch
from
a17cf8e
to
5a81f39
Compare
yyoncho
approved these changes
Nov 1, 2022
|
Thank you! |
| :initialization-options (lambda () (ht-merge (lsp-configuration-section "typescript") | ||
| (lsp-configuration-section "documentFeatures"))) | ||
| (ht ("serverMode" 0) | ||
| ("diagnosticMode" 1) |
There was a problem hiding this comment.
Here are a wrong field: diagnosticMode -> diagnosticModel
There was a problem hiding this comment.
Thanks for your correction, I will fix it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Volar has update the options for the language server. See vuejs/language-tools#1916 .
And fix #3785