Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider adding named blocks #32

Open
pzuraq opened this issue Mar 14, 2021 · 4 comments · May be fixed by #36
Open

Consider adding named blocks #32

pzuraq opened this issue Mar 14, 2021 · 4 comments · May be fixed by #36
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@pzuraq
Copy link

pzuraq commented Mar 14, 2021

Is your feature request related to a problem? Please describe.

Not really, it would just be convenient.

Describe the solution you'd like

It'd be nice to be able to use named blocks instead of @displayKey to show what the value should look like, something like:

<SelectLight
  @value={{this.selected}}
  @options={{this.options}}
  @change={{this.handleChange}} 
>
  <:option as |value|>
   {{value.name}}
  </option>
<SelectLight>
class MyComponent extends Component {
  options = [{
    id: 1,
    name: "turtle",
  }, {
    id: 2,
    name: "mako",
  }];

  @tracked selected = this.options[0];
}
@hergaiety hergaiety added enhancement New feature or request good first issue Good for newcomers labels Mar 19, 2021
@colenso
Copy link

colenso commented Mar 29, 2021

I'll try looking at this

@hergaiety
Copy link

I'll try looking at this

Sounds good, thanks! I'm @gaiety#0001 on Discord if you have questions on anything :)
I'll also throw @pzuraq#9034 under the bus who wrote this issue and is also a mentor for the contributors workshop as well.

@colenso
Copy link

colenso commented Mar 29, 2021

So, named blocks are only available in ember 3.25 right? And this project still uses 3.23?

@colenso colenso mentioned this issue Mar 29, 2021
Closed
@colenso
Copy link

colenso commented Mar 29, 2021 •
edited

Made a separate issue for this ☝️ #34

@colenso colenso linked a pull request Mar 29, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use named blocks instead of displayKey colenso/ember-select-light
3 participants
@pzuraq @hergaiety @colenso