Use named blocks instead of displayKey #36
Conversation
|
Hmmm.. Looks like tests are failing in older ember versions which don't have named block support. |
Yep that would make sense. Perhaps it's best to adjust the versions ember try uses or skip ember try altogether for now until more versions support it. With this upgrade we'll likely be bumping this package as a major version change anyway, declaring we're only supporting Ember versions after the one with named blocks. Over time ember try can check more versions again when more Ember versions moving forward have support. |
|
Tests passed |
Great! I'd love to give it a try a little later. Thanks so much for your work on this! |
|
Just wanted to say sorry for not getting to this yet. It's been weird (but good) in my personal world lately and I haven't been in open source much since Ember Conf. I'll get to this when I can though~ |
| @valueKey="val" | ||
| @displayKey="description" /> | ||
| @valueKey="val"> | ||
| <:option as |optionValue| >{{optionValue.description}}</:option> |
There was a problem hiding this comment.
With this new style, it seems more like we are yielding the entire option and not just the option value. So perhaps this is more appropriate.
| <:option as |optionValue| >{{optionValue.description}}</:option> | |
| <:option as |currentOption| >{{currentOption.description}}</:option> |
| @@ -153,8 +153,9 @@ module('Integration | Component | select-light', function(hooks) { | |||
| <SelectLight | |||
| @options={{this.options}} | |||
| @value={{this.value}} | |||
| @valueKey="val" | |||
| @displayKey="description" /> | |||
| @valueKey="val"> | |||
There was a problem hiding this comment.
This test no longer passes in a @displayKey so the test description could be adjusted to reflect this. Something like should render a named option block with a customized value key when passed array of objects perhaps.
It could then be good to add another test that uses a custom passed in @displayKey
| @@ -15,7 +15,11 @@ | |||
| <option | |||
| value={{get optionValue this.valueKey}} | |||
| selected={{is-equal (get optionValue this.valueKey) @value}}> | |||
| {{get optionValue this.displayKey}} | |||
| {{#if @valueKey}} | |||
There was a problem hiding this comment.
| {{#if @valueKey}} | |
| {{#if (has-block "option")}} |
Close! I think this could follow the following pattern rather than relying on the seemingly unrelated (but passing the test) @valueKey
https://github.com/emberjs/ember.js/pull/19318/files#diff-08e773e2dfe82a277c4837362632f2e6d5d2d18137feaa80456e7d0537ff37d8R185
Closes #32