-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Convert BsDropdown to TypeScript #2109
base: master
Are you sure you want to change the base?
Conversation
@@ -0,0 +1,6 @@ | |||
export default function bsDefault<T, U>( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file has been taken from #2112.
@@ -1,37 +1,41 @@ | |||
/* eslint-disable @typescript-eslint/no-explicit-any */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file has been taken from #2112.
@@ -0,0 +1,4 @@ | |||
export default interface EmbroiderConfig { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if addon/utils/embroider-config.d.ts
is the right location for this interface. Sharing best practices is highly appreciated. 😸
Converts
<BsDropdown>
and its sub-components to TypeScript.