Skip to content

Commit

Permalink
Handle relative paths when fixing keys (#390)
Browse files Browse the repository at this point in the history
* Handle relative paths when fixing keys

* Fix issue with embroider
  • Loading branch information
wagenet committed Nov 7, 2023
1 parent 101e39f commit 3034bae
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions packages/ember-cli-code-coverage/lib/attach-middleware.js
Original file line number Diff line number Diff line change
Expand Up @@ -69,11 +69,16 @@ function adjustCoverageKey(
modifyAssetLocation
) {
let relativePath = path.relative(root, filepath);

let embroiderTmpPathRegex = /embroider\/.{6}/gm;

// we can determine if file is coming from embroider based on how the path looks
if (embroiderTmpPathRegex.test(filepath)) {
relativePath = normalizeRelativePath(root, filepath);
} else if (relativePath.startsWith('..')) {
// This lives in a directory outside of the current one, likely a monorepo.
// In this case we can assume that the original path is correct.
return filepath;
}

let namespace = relativePath.split(path.sep)[0];
Expand Down

0 comments on commit 3034bae

Please sign in to comment.