embroider app tests & use @embroider as peerDeps #382
Conversation
AmauryD
changed the title
AmauryD
force-pushed
the
master
branch
2 times, most recently
from
d05bfaf
to
fcd1f20
Compare
|
Just tested this out in our app, and it does seem to fix #374. I was able to workaround the sub-directory github link limitation mentioned in #374 (comment) by using https://gitpkg.vercel.app/: "ember-cli-code-coverage": "https://gitpkg.now.sh/AmauryD/ember-cli-code-coverage/packages/ember-cli-code-coverage?master" |
|
I'll repeat what I wrote in the issue for the visibility - I confirm the change fixes the problem for us 👍 |
|
I tested this out in our app (using the |
| @@ -91,6 +89,18 @@ | |||
| "release-it-lerna-changelog": "^2.3.0", | |||
| "sinon": "^4.2.2" | |||
| }, | |||
| "peerDependencies": { | |||
| "@embroider/compat": "^0.47.0 || ^1.0.0 || ^2.0.0 || ^3.0.0", | |||
There was a problem hiding this comment.
Can you loosen these to make the last >=3.0.0? That way if it happens to work with 4.0 or further, we don't have to release just to bump the peer dep?
There was a problem hiding this comment.
done ! Thank's for the review
test-packages/.DS_Store
Outdated
There was a problem hiding this comment.
I think this is an accidentally committed file
There was a problem hiding this comment.
yes, it is. I added .DS_Store files to gitignore
.DS_Store
Outdated
There was a problem hiding this comment.
Seems like another DS_Store made it in
There was a problem hiding this comment.
Done ! It was the last one.
|
Thank you! |
@AmauryD if the offer still stands, I would love help converting to pnpm. It seems the tests you added are failing in the master branch now, and I am not sure why. Also to note, #387 makes some embroider tweaks and I think we should probably get that in too. Would love your help getting this stuff sorted out and getting tests passing again ❤️ |
It will be a pleasure to help ! I'll take a look in my free time 😄 |
|
Thank you @AmauryD! |
Fixes #374 by using the app installed @embroider/compat.
Note: if you want i can help moving from yarn 1 to pnpm. It was a nightmare to deal with the dependencies of the test-packages.