Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to pnpm for Workspace Management and Tests Refactoring. #398

Merged
merged 3 commits into from Nov 14, 2023

Conversation

AmauryD
Copy link
Contributor

@AmauryD AmauryD commented Nov 9, 2023

@RobbieTheWagner I started to work on the pnpm conversion. But i have a few questions considering the tests.

Should we consider keeping the test applications on Ember 3.x, or is it advisable to update them to at least the lowest LTS release (4.4)?
Should we drop the support of old Embroider versions (<= 1.0.0) ?
Perhaps we should explore alternative methods for testing these test-apps, allowing for isolation from each other, and potentially enabling concurrent launches with varying dependency versions. Similar to what ember-try does.

I tried adding the test packages in the workspace, but the tests for the Embroider app are failing 50% of the time. I'll try again later.

@AmauryD
Copy link
Contributor Author

AmauryD commented Nov 12, 2023

Not quite what I had in mind. Despite my efforts to maximize the speed of the embroider tests. Replacing dependencies necessitates reinstalling them, which is still quite time-consuming. At least it's consistent.

@AmauryD
Copy link
Contributor Author

AmauryD commented Nov 12, 2023

Here's the summary of my changes:

@AmauryD AmauryD changed the title Switch to pnpm for Workspace Management and Refactoring. Switch to pnpm for Workspace Management and Tests Refactoring. Nov 12, 2023
@AmauryD AmauryD marked this pull request as ready for review November 12, 2023 18:54
Copy link
Collaborator

@RobbieTheWagner RobbieTheWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, thank you!

@RobbieTheWagner RobbieTheWagner merged commit b9b5f79 into ember-cli-code-coverage:master Nov 14, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants