Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Node 4 #105

Merged
merged 1 commit into from Jan 14, 2019
Merged

Drop support for Node 4 #105

merged 1 commit into from Jan 14, 2019

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Jan 14, 2019

#69 dropped Node 4 from the CI config, but we never actually officially dropped support for it. This PR changes the compatibility declaration in the package.json file accordingly and will have to result in a major version bump as this is a breaking change.

/cc @luxferresum @stefanpenner

@Turbo87 Turbo87 requested a review from a team January 14, 2019 10:31
Copy link
Collaborator

@stefanpenner stefanpenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as it comes with a major version bump.

@Turbo87 Turbo87 merged commit cf6f7f2 into ember-cli:master Jan 14, 2019
@Turbo87 Turbo87 deleted the drop-node-4 branch January 15, 2019 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants