Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Node < 10 support; Upgrade ember-cli-babel to ^7.0.0. #295

Merged
merged 1 commit into from Oct 9, 2020
Merged

Drop Node < 10 support; Upgrade ember-cli-babel to ^7.0.0. #295

merged 1 commit into from Oct 9, 2020

Conversation

nlfurniss
Copy link
Contributor

No description provided.

@nlfurniss
Copy link
Contributor Author

Tests fail on this line where owner is undefined when the version fo Ember is not ancient. Will dig in

rwjblue
rwjblue reviewed Sep 24, 2020
View reviewed changes
Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably needs to be >= 10 (since 10 is still a supported release)

@rwjblue rwjblue changed the title upgrade ember-cli-babel to ^7.0.0 Drop Node < 10 support; Upgrade ember-cli-babel to ^7.0.0. Oct 9, 2020
@rwjblue rwjblue merged commit 15a23fe into ember-cli:master Oct 9, 2020
@nlfurniss nlfurniss deleted the upgrade-ember-cli-babel branch October 9, 2020 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue left review comments

Assignees
No one assigned
Labels
breaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nlfurniss @rwjblue