Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace git-repo-version dependency with git-repo-info #68

Merged
merged 3 commits into from Jan 14, 2019

Conversation

luxzeitlos
Copy link
Contributor

remove depdendency on cibernox/git-repo-version and directly use rwjblue/git-repo-info.

This is basically #64. Currently I have not migrated any tests, because I think the existing tests should reflect our public API. Next we can internally refactor and maybe support a bit a more advanced API and so close some issues.

…lue/git-repo-info

previously this used cibernox/git-repo-version and rwjblue/git-repo-info was used by cibernox/git-repo-version.
Now the code from cibernox/git-repo-version was migrated to this repo effectifly cutting the middleman.
@Turbo87 Turbo87 changed the title remove depdendency on cibernox/git-repo-version and directly use rwjb… Replace git-repo-version dependency with git-repo-info Jan 14, 2019
Copy link
Member

@Turbo87 Turbo87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

according to the comments in #64 it looks like everyone agrees that this is a valuable change. I have rebased the PR to resolve the lockfile merge conflict and IMHO this is ready to be merged once CI has passed

@Turbo87 Turbo87 merged commit 60cb3b9 into ember-cli:master Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants