Export non-user-constructible TemplateFactory type
#764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows users who need to name the type (e.g. for custom wiring with `setComponentTemplate`) to do so, while making it so that the type can *only* be constructed by calling `hbs()` in type terms *and* in the documentation for the item. Additionally, drop type-level compatibility with the export from `htmlbars-inline-precompile`, which was deprecated years ago, long before official TS support in this library.
bertdeblock
approved these changes
Feb 14, 2023
dfreeman
approved these changes
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows users who need to name the type (e.g. for custom wiring with
setComponentTemplate) to do so, while making it so that the type can only be constructed by callinghbs()in type terms and in the documentation for the item. Additionally, drop type-level compatibility with the export fromhtmlbars-inline-precompile, which was deprecated years ago, long before official TS support in this library.This makes the blueprints generated when running
ember-cli-typescript's generators type check correctly. While we do not recommend usingtemplateimports directly, many existing applications do so.