Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] Deprecate outputPaths build option #10162

Merged

Conversation

bertdeblock
Copy link

Closes #9478.

@bertdeblock
Copy link
Author

Draft, as I don't think we can land this before v5.1.0.

@locks
Copy link
Contributor

locks commented Jul 24, 2023

@bertdeblock I think it's time 😅 Might need to update the version values.

@NullVoxPopuli
Copy link
Contributor

NullVoxPopuli commented Jul 24, 2023

what would they be? 5.2 or 5.3?

5.2 is still beta, so.. 5.2?
(or does beta have its own branch, so we'd have to do 5.3?)

@bertdeblock bertdeblock force-pushed the deprecate-outputPaths-build-option branch from 869dc8a to 855edcf Compare July 25, 2023 13:39
@bertdeblock
Copy link
Author

bertdeblock commented Jul 25, 2023

Updated. Beta has its own branch, so master should be 5.3.0 at the moment. Made this MR a while ago, so best to check if we actually can / want to land this deprecation at this time.

@bertdeblock bertdeblock marked this pull request as ready for review July 25, 2023 13:41
@ef4 ef4 merged commit fe119ad into ember-cli:master Jul 25, 2023
12 checks passed
@boris-petrov
Copy link
Contributor

I can't seem to find a migration path anywhere. What are we supposed to change outputPaths with?

@bertdeblock
Copy link
Author

It was deprecated without a replacement if I remember correctly:
https://deprecations.emberjs.com/ember-cli/v5.x#toc_ember-cli-outputPaths-build-option

@boris-petrov
Copy link
Contributor

I am using it to output different CSS files for different themes. So I'll have to check how to do that with webpack I suppose?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate outputPaths usage under Embroider
5 participants