Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX beta] App blueprint may not have explicit-any in ember-data types #10345

Merged
merged 2 commits into from
Aug 21, 2023

Conversation

NullVoxPopuli
Copy link
Contributor

@NullVoxPopuli NullVoxPopuli commented Aug 19, 2023

Discovered over here: https://github.com/embroider-build/addon-blueprint/actions/runs/5912329738/job/16035634804?pr=188

In --typescript projects, we use

      extends: [
        'plugin:@typescript-eslint/eslint-recommended',
        'plugin:@typescript-eslint/recommended',
      ],

which then immediately fails lint / lint:fix due to the above configs having @typescript-eslint/no-explicit-any so we need to disable the rule for ember-data's model registry.

Unblocks: embroider-build/addon-blueprint#188

@NullVoxPopuli NullVoxPopuli changed the title App blueprint may not have explicit-any App blueprint may not have explicit-any in ember-data types Aug 19, 2023
@NullVoxPopuli NullVoxPopuli changed the title App blueprint may not have explicit-any in ember-data types [BUGFIX beta] App blueprint may not have explicit-any in ember-data types Aug 21, 2023
@NullVoxPopuli NullVoxPopuli added this pull request to the merge queue Aug 21, 2023
Merged via the queue into master with commit 50a6537 Aug 21, 2023
11 checks passed
@NullVoxPopuli NullVoxPopuli deleted the NullVoxPopuli-patch-3 branch August 21, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants