fix GitHub Action floating deps scenario for PNPM

[jelhan]

The Floating Dependencies scenario is broken for a newly created Ember addon using PNPM. This change fixes it.

It seems that wyvox/action-setup-pnpm's no-lockfile option is not working as expected. It throws the following error:

Error: Dependencies lock file is not found in /home/runner/work/test-ember-addon-with-pnpm/test-ember-addon-with-pnpm. Supported file patterns: pnpm-lock.yaml

The option has been removed in wyvox/action-setup-pnpm@v3. So upgrading is not an option. But using --no-lockfile flag of PNPM is the recommended upgrade path anyways: wyvox/action-setup-pnpm#3

Please find a demonstration of the bug here: https://github.com/jelhan/test-ember-addon-with-pnpm/actions/runs/7453402485/job/20278700434

A demonstration that the fix work could be found here: jelhan/test-ember-addon-with-pnpm#1

@NullVoxPopuli would be great if you could review. I think you are the expert here as you implemented the PNPM support in Ember CLI and maintain wyvox/action-setup-pnpm.

[NullVoxPopuli]

yeah, the things you call out are exactly the motivation for the change in v3 👍

So upgrading is not an option.

Upgrading to v3 should done (probably as separate PR), as there are important fixes in there (specifically around determining what tooling versions to use, based on your package.json (inherited upstream by way of upgrading setup-node and configuring it))

[jelhan]

Thanks a lot for quick review.

So upgrading is not an option.

Upgrading to v3 should done (probably as separate PR), as there are important fixes in there (specifically around determining what tooling versions to use, based on your package.json (inherited upstream by way of upgrading setup-node and configuring it))

Sorry. I phrased it badly. I meant, upgrading is not an option to fix this bug. The changes landed with this PR unlock the upgrade. The upgrade to wyvox/action-setup-pnpm@v3 should only require bumping the version number now. At least that's what RenovateBot done in my project and it worked find. 😆