Use Babel 6 #6828

rwjblue · 2017-03-06T01:46:22Z

This is the starting point for using babel@6 in ember-cli itself and apps. This mostly includes various fallback paths that we have provided that ensure "things are transpiled", without much guarantee about actual transpilation content.

It also paves the way for allowing the usage of ember-cli-babel@6 by providing this.options.babel as needed based on ember-cli-babel version in use.

Utilizes the new project.targets to provide custom transpilation configuration based on project targets.

Release final stable version of ember-cli-babel@6 (Babel 6 emberjs/ember-cli-babel#115)
Release final stable version of ember-cli-htmlbars-inline-precompile for babel@6 support

Fixes #5015.

rwjblue · 2017-03-06T01:54:13Z

package.json

    "bower-config": "^1.3.0",
    "bower-endpoint-parser": "0.2.2",
-    "broccoli-babel-transpiler": "^5.6.2",
+    "broccoli-babel-transpiler": "6.0.0-alpha.3",


This is the primary "merge blocker". Need to release as something > .alpha to land (IMO).

cibernox · 2017-03-06T09:27:46Z

lib/utilities/default-targets.js

+module.exports = {
+  browsers: [
+    'ie 9',
+    'last 1 Chrome versions',


This is totally outside the scope but here we go:
This matrix is the actual matrix of browsers in which ember itself is tested. I believe that probably safari 9 should be added to ember's test matrix. Arguably today iOS9 is far more relevant than ie9 & 10 combined.

No argument there. In this PR I'm just taking advantage of the new targets, so I refactored to a separate util to avoid duplication.

cibernox · 2017-03-06T11:38:33Z

lib/utilities/babel-config-for-targets.js

@@ -0,0 +1,17 @@
+'use strict';
+const presetEnv = require('babel-preset-env').default;


Should the babel-preset-env live here or can it be part ember-cli-babel?

The idea is that ember-cli-babel is "just" transpiling with the provided config options. I am not really opposed to flip flopping if folks feel strongly...

This was good advice, moved this logic to ember-cli-babel (in emberjs/ember-cli-babel@78b0342).

homu · 2017-03-08T19:27:12Z

☔ The latest upstream changes (presumably 6eccb8f) made this pull request unmergeable. Please resolve the merge conflicts.

homu · 2017-03-10T22:35:33Z

☔ The latest upstream changes (presumably #6835) made this pull request unmergeable. Please resolve the merge conflicts.

rwjblue · 2017-03-12T03:11:11Z

lib/broccoli/babel-process-modules-only.js

+    plugins: [
+      // this sucks, but :goodnews: once a new version of babel@6 is released
+      // we can remove this in favor of `babel-plugin-transform-es2015-modules-amd`
+      [require('rwjblue-custom-babel-6-amd-modules-no-interop'), { loose: true, noIterop: true }],


clearly not ideal, but seems ok so that we aren't blocked hard on a release...

rwjblue · 2017-03-12T03:20:12Z

Things that are done:

update the app blueprint to use ember-cli-babel@6 (alpha for now)
change all fallback paths to only process modules (this was the only guarantee anyways)
ensure the default babel options are populated based on ember-cli-babel version
ensure ember-cli-babel@6 can be used with ember-cli@2.11.1 and ember-cli@2.12 (likely older though I haven't tested yet)
ensure ember-cli-htmlbars-inline-precompiler@0.4.0-beta.1 (babel@6 version) is working properly in conjunction with ember-cli@2.11 and ember-cli@2.12
published custom build of babel@6 (from babel's master branch) that includes the changes needed to emit modules that can interop between babel@5 and babel@6

This is ready to start reviewing (code wise), I'm still working through a couple test failures ATM though...

* Updates ember-cli itself to use babel@6. * Removes usages of `options.babel` for internal babel version. * Removes `_pruneBabelOptions` method.

* Use private internal babel options for methods using ember-cli shipped babel transpiler. * Provide babel options based upon ember-cli-babel version (for babel@5 give babel@5 style options, for babel@6 give babel@6 style options). Provide `this.options.babel` based on

* Remove usage of `babel-preset-env`. * Change all "fallback" processing to handle **only** modules.

When using ember-cli-babel@5 use babel@5 options, when using ember-cli-babel@6 no defaults are needed.

Fixes an issue with using babel@6 options when transpiling with babel@5.

stefanpenner · 2017-03-12T18:11:46Z

lib/broccoli/babel-process-modules-only.js

+    plugins: [
+      // this sucks, but :goodnews: once a new version of babel@6 is released
+      // we can remove this in favor of `babel-plugin-transform-es2015-modules-amd`
+      [require('rwjblue-custom-babel-6-amd-modules-no-interop'), { loose: true, noIterop: true }],


The RFC has landed, and ember-cli-babel has been updated to take advantage of it. Having real use cases was the blocker to enabling the feature flag and removing it.

babel@6.24 includes the required interop changes.

Fixes some bugs.

rwjblue · 2017-03-13T15:36:24Z

@homu r+

homu · 2017-03-13T15:36:25Z

📌 Commit e2a6db2 has been approved by rwjblue

homu · 2017-03-13T15:36:40Z

⚡ Test exempted - status

Use Babel 6 This is the starting point for using babel@6 in ember-cli itself and apps. This mostly includes various fallback paths that we have provided that ensure "things are transpiled", without much guarantee about actual transpilation content. It also paves the way for allowing the usage of ember-cli-babel@6 by providing `this.options.babel` as needed based on ember-cli-babel version in use. Utilizes the new `project.targets` to provide custom transpilation configuration based on project targets. --- - [ ] Release final stable version of ember-cli-babel@6 (emberjs/ember-cli-babel#115) - [ ] Release final stable version of ember-cli-htmlbars-inline-precompile for babel@6 support Fixes #5015.

rwjblue commented Mar 6, 2017

View reviewed changes

cibernox reviewed Mar 6, 2017

View reviewed changes

rwjblue force-pushed the babel-6-internally branch from cbd5447 to 477b2da Compare March 6, 2017 15:06

rwjblue force-pushed the babel-6-internally branch from f891dfb to 51fda8b Compare March 10, 2017 13:57

rwjblue force-pushed the babel-6-internally branch from 51fda8b to eb435c9 Compare March 12, 2017 03:05

rwjblue commented Mar 12, 2017

View reviewed changes

rwjblue changed the title ~~[WIP] Use Babel 6 internally.~~ Use Babel 6 Mar 12, 2017

rwjblue requested review from stefanpenner and Turbo87 March 12, 2017 03:20

rwjblue added 12 commits March 12, 2017 13:05

Use babel@6 internally.

bf757cc

* Updates ember-cli itself to use babel@6. * Removes usages of `options.babel` for internal babel version. * Removes `_pruneBabelOptions` method.

Migrate default set of targets to utility.

795fe4e

Extract processModulesOnly to shared utility.

48b38fc

When ember-cli-babel is not present in app, only process modules.

e430746

Ensure all fallback transpilation is modules only.

1fcb3e3

* Remove usage of `babel-preset-env`. * Change all "fallback" processing to handle **only** modules.

Update blueprint deps to babel@6 versions.

dd51e7f

Default babel options based on ember-cli-babel version.

3164a07

When using ember-cli-babel@5 use babel@5 options, when using ember-cli-babel@6 no defaults are needed.

Add custom fork of babel@6's master until a version is released.

5fc5cc6

Update yarn.lock.

c27e9e1

Set babel@5 fallback modules format to amdStrict.

00dac68

Bump minimum version of ember-cli-qunit.

fa3af6a

Fixes an issue with using babel@6 options when transpiling with babel@5.

rwjblue force-pushed the babel-6-internally branch from 791787b to fa3af6a Compare March 12, 2017 17:06

stefanpenner approved these changes Mar 12, 2017

View reviewed changes

rwjblue mentioned this pull request Mar 12, 2017

Babel 6.0 #5015

Closed

17 tasks

Update vendor shims blueprint to emit __esModule flag.

381f51a

stefanpenner approved these changes Mar 12, 2017

View reviewed changes

Remove feature flagging for browser targets RFC.

2b4ab62

The RFC has landed, and ember-cli-babel has been updated to take advantage of it. Having real use cases was the blocker to enabling the feature flag and removing it.

rwjblue force-pushed the babel-6-internally branch from a102fb3 to 2b4ab62 Compare March 12, 2017 22:42

frederikbosch mentioned this pull request Mar 13, 2017

dynamic import syntax transformation in Ember CLI ember-cli/rfcs#98

Closed

rwjblue added 2 commits March 13, 2017 11:01

Remove custom modules transpilation plugin.

02b0a1e

babel@6.24 includes the required interop changes.

Update to latest htmlbars-inline-precompile plugin.

e2a6db2

Fixes some bugs.

homu merged commit e2a6db2 into master Mar 13, 2017

homu mentioned this pull request Mar 13, 2017

tests: Remove unused variables #6853

Merged

rwjblue deleted the babel-6-internally branch March 13, 2017 15:39

twokul mentioned this pull request Aug 30, 2017

Removes babel module transform #7314

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use Babel 6 #6828

Use Babel 6 #6828

rwjblue commented Mar 6, 2017 •

edited

rwjblue Mar 6, 2017

cibernox Mar 6, 2017 •

edited by stefanpenner

rwjblue Mar 6, 2017

cibernox Mar 6, 2017

rwjblue Mar 6, 2017

rwjblue Mar 6, 2017

homu commented Mar 8, 2017

homu commented Mar 10, 2017

rwjblue Mar 12, 2017

stefanpenner Mar 12, 2017

rwjblue commented Mar 12, 2017

stefanpenner Mar 12, 2017

rwjblue commented Mar 13, 2017

homu commented Mar 13, 2017

homu commented Mar 13, 2017

		@@ -0,0 +1,17 @@
		'use strict';
		const presetEnv = require('babel-preset-env').default;

Use Babel 6 #6828

Use Babel 6 #6828

Conversation

rwjblue commented Mar 6, 2017 • edited

Choose a reason for hiding this comment

cibernox Mar 6, 2017 • edited by stefanpenner

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

homu commented Mar 8, 2017

homu commented Mar 10, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rwjblue commented Mar 12, 2017

Choose a reason for hiding this comment

rwjblue commented Mar 13, 2017

homu commented Mar 13, 2017

homu commented Mar 13, 2017

rwjblue commented Mar 6, 2017 •

edited

cibernox Mar 6, 2017 •

edited by stefanpenner