Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update @embroider/* packages to 1.0.0. #9762

Merged
merged 2 commits into from Jan 21, 2022
Merged

Update @embroider/* packages to 1.0.0. #9762

merged 2 commits into from Jan 21, 2022

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented Jan 19, 2022

No description provided.

These seem to be a bit unstable on Windows (lots of failures, but it's
really just taking too long).
@rwjblue rwjblue merged commit a2b2832 into release Jan 21, 2022
@rwjblue rwjblue deleted the update-embroider branch January 21, 2022 19:04
@jelhan
Copy link
Contributor

jelhan commented Jan 22, 2022

I just noticed that a newly created application using Ember CLI 4.1.0 and --embroider flag throws at build-time:

Build Error (PackagerRunner) in ../../../home/foo/tmp/test-embroider/node_modules/@glimmer/component/dist/modules/es2017/src/component-manager.js

Module not found: Error: Can't resolve '@glimmer/application' in '/home/foo$TMPDIR/test-embroider/node_modules/@glimmer/component/dist/modules/es2017/src/component-manager.js'

This could be fixed by upgrading @embroider/* to 1.0.0. Please see here for more context: https://discord.com/channels/480462759797063690/568935504288940056/934424928265072640

Wondering if this upgrade should be backported to Ember CLI v4.1.0. Or at least be released as a new beta version for v4.2.0.

@kategengler
Copy link
Member

@jelhan Thanks for reporting. This fix merged to the #release branch and so will be released as a 4.1 patch release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants