Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport types to 8.x #839

Merged
merged 2 commits into from
Dec 20, 2022
Merged

Backport types to 8.x #839

merged 2 commits into from
Dec 20, 2022

Conversation

chriskrycho
Copy link
Contributor

This just back-ports af9db19 and 769ad35 from the v9.0.0 release to v8.x so make it possible for folks to get native types here (still using @types packages) while still on Ember 3.x. We'll release this as 8.1.0.

Verified

This commit was signed with the committer’s verified signature.
chriskrycho Chris Krycho
Ultimately we'd like to convert the package to TS, but this unblocks
wider ecosystem adoption of the stable/preview Ember types. This PR can
also serve as a model for other packages which want to publish types in
a similar way.

This will also work just fine with the `@types` packages from
DefinitelyTyped once [a key PR][pr] lands there, but that is not the
path we will recommend, so this only includes the `ember-source` peer
dependency.

[pr]: DefinitelyTyped/DefinitelyTyped#63589

(cherry picked from commit 3907d48)

# Conflicts:
#	addon/package.json
#	package-lock.json
#	test-app/package.json

Verified

This commit was signed with the committer’s verified signature.
chriskrycho Chris Krycho
Without this, it doesn't get exported as a class people can actually
instantiate with `Resolver.create()`.

(cherry picked from commit 67fc6c4)
@chriskrycho
Copy link
Contributor Author

It's obviously not going to pass on v4; the whole point here is to back-port support to v3. 🙃

@chriskrycho chriskrycho merged commit b6f7fef into release-8-x Dec 20, 2022
@chriskrycho chriskrycho deleted the backport-types branch December 20, 2022 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant