Backport types to 8.x #839
Merged
+16
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ultimately we'd like to convert the package to TS, but this unblocks wider ecosystem adoption of the stable/preview Ember types. This PR can also serve as a model for other packages which want to publish types in a similar way. This will also work just fine with the `@types` packages from DefinitelyTyped once [a key PR][pr] lands there, but that is not the path we will recommend, so this only includes the `ember-source` peer dependency. [pr]: DefinitelyTyped/DefinitelyTyped#63589 (cherry picked from commit 3907d48) # Conflicts: # addon/package.json # package-lock.json # test-app/package.json
Without this, it doesn't get exported as a class people can actually instantiate with `Resolver.create()`. (cherry picked from commit 67fc6c4)
|
It's obviously not going to pass on v4; the whole point here is to back-port support to v3. 🙃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just back-ports af9db19 and 769ad35 from the v9.0.0 release to v8.x so make it possible for folks to get native types here (still using
@typespackages) while still on Ember 3.x. We'll release this as 8.1.0.