Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Resolver to Native Class #902

Merged
merged 2 commits into from
May 2, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
64 changes: 31 additions & 33 deletions addon/addon/resolvers/classic/index.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
/* globals requirejs, require */

/* eslint-disable ember/no-classic-classes */

import Ember from 'ember';
import { assert, deprecate, warn } from '@ember/debug';
import EmberObject from '@ember/object';
Expand Down Expand Up @@ -130,22 +128,22 @@ function resolveOther(parsedName) {
}
}

const Resolver = EmberObject.extend({
resolveOther,
parseName,
pluralizedTypes: null,
moduleRegistry: null,
class Resolver extends EmberObject {
rwjblue marked this conversation as resolved.
Show resolved Hide resolved
resolveOther = resolveOther;
parseName = parseName;
elwayman02 marked this conversation as resolved.
Show resolved Hide resolved
pluralizedTypes = null;
moduleRegistry = null;
elwayman02 marked this conversation as resolved.
Show resolved Hide resolved

makeToString(factory, fullName) {
return '' + this.namespace.modulePrefix + '@' + fullName + ':';
},
}

shouldWrapInClassFactory(/* module, parsedName */){
return false;
},
}

init() {
this._super();
constructor() {
super(...arguments);
this.moduleBasedResolver = true;

if (!this._moduleRegistry) {
Expand Down Expand Up @@ -177,11 +175,11 @@ const Resolver = EmberObject.extend({
this.defaultModuleName,
this.nestedColocationComponentModuleName,
];
},
}

normalize(fullName) {
return this._normalizeCache[fullName] || (this._normalizeCache[fullName] = this._normalize(fullName));
},
}

resolve(fullName) {
let parsedName = this.parseName(fullName);
Expand All @@ -197,7 +195,7 @@ const Resolver = EmberObject.extend({
}

return resolved;
},
}

_normalize(fullName) {
// A) Convert underscores to dashes
Expand Down Expand Up @@ -226,11 +224,11 @@ const Resolver = EmberObject.extend({
} else {
return fullName;
}
},
}

pluralize(type) {
return this.pluralizedTypes[type] || (this.pluralizedTypes[type] = type + 's');
},
}

podBasedLookupWithPrefix(podPrefix, parsedName) {
let fullNameWithoutType = parsedName.fullNameWithoutType;
Expand All @@ -240,13 +238,13 @@ const Resolver = EmberObject.extend({
}

return podPrefix + '/' + fullNameWithoutType + '/' + parsedName.type;
},
}

podBasedModuleName(parsedName) {
let podPrefix = this.namespace.podModulePrefix || this.namespace.modulePrefix;

return this.podBasedLookupWithPrefix(podPrefix, parsedName);
},
}

podBasedComponentsInSubdir(parsedName) {
let podPrefix = this.namespace.podModulePrefix || this.namespace.modulePrefix;
Expand All @@ -255,7 +253,7 @@ const Resolver = EmberObject.extend({
if (parsedName.type === 'component' || /^components/.test(parsedName.fullNameWithoutType)) {
return this.podBasedLookupWithPrefix(podPrefix, parsedName);
}
},
}

resolveEngine(parsedName) {
let engineName = parsedName.fullNameWithoutType;
Expand All @@ -264,7 +262,7 @@ const Resolver = EmberObject.extend({
if (this._moduleRegistry.has(engineModule)) {
return this._extractDefaultExport(engineModule);
}
},
}

resolveRouteMap(parsedName) {
let engineName = parsedName.fullNameWithoutType;
Expand All @@ -277,32 +275,32 @@ const Resolver = EmberObject.extend({

return routeMap;
}
},
}

resolveTemplate(parsedName) {
let resolved = this.resolveOther(parsedName);
if (resolved == null) {
resolved = Ember.TEMPLATES[parsedName.fullNameWithoutType];
}
return resolved;
},
}

mainModuleName(parsedName) {
if (parsedName.fullNameWithoutType === 'main') {
// if router:main or adapter:main look for a module with just the type first
return parsedName.prefix + '/' + parsedName.type;
}
},
}

defaultModuleName(parsedName) {
return parsedName.prefix + '/' + this.pluralize(parsedName.type) + '/' + parsedName.fullNameWithoutType;
},
}

nestedColocationComponentModuleName(parsedName) {
if (parsedName.type === 'component') {
return parsedName.prefix + '/' + this.pluralize(parsedName.type) + '/' + parsedName.fullNameWithoutType + '/index';
}
},
}

prefix(parsedName) {
let tmpPrefix = this.namespace.modulePrefix;
Expand All @@ -312,7 +310,7 @@ const Resolver = EmberObject.extend({
}

return tmpPrefix;
},
}

findModuleName(parsedName, loggingDisabled){
let moduleNameLookupPatterns = this.moduleNameLookupPatterns;
Expand Down Expand Up @@ -341,7 +339,7 @@ const Resolver = EmberObject.extend({
return moduleName;
}
}
},
}

chooseModuleName(moduleName, parsedName) {
let underscoredModuleName = underscore(moduleName);
Expand Down Expand Up @@ -392,7 +390,7 @@ const Resolver = EmberObject.extend({
}
}
}
},
}

// used by Ember.DefaultResolver.prototype._logLookup
lookupDescription(fullName) {
Expand All @@ -401,7 +399,7 @@ const Resolver = EmberObject.extend({
let moduleName = this.findModuleName(parsedName, true);

return moduleName;
},
}

// only needed until 1.6.0-beta.2 can be required
_logLookup(found, parsedName, description) {
Expand All @@ -426,7 +424,7 @@ const Resolver = EmberObject.extend({
if (console && console.info) {
console.info(symbol, parsedName.fullName, padding, description);
}
},
}

knownForType(type) {
let moduleKeys = this._moduleRegistry.moduleNames();
Expand All @@ -442,7 +440,7 @@ const Resolver = EmberObject.extend({
}

return items;
},
}

translateToContainerFullname(type, moduleName) {
let prefix = this.prefix({ type });
Expand All @@ -468,7 +466,7 @@ const Resolver = EmberObject.extend({
if (moduleName.indexOf(nonPodPrefix) === 0 && moduleName.length > nonPodPrefix.length) {
return type + ':' + moduleName.slice(nonPodPrefix.length);
}
},
}

_extractDefaultExport(normalizedModuleName) {
let module = this._moduleRegistry.get(normalizedModuleName, null, null, true /* force sync */);
Expand All @@ -479,7 +477,7 @@ const Resolver = EmberObject.extend({

return module;
}
});
}

Resolver.reopenClass({
elwayman02 marked this conversation as resolved.
Show resolved Hide resolved
moduleBasedResolver: true
Expand Down