Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecate to @ember/debug #431

Merged

Conversation

NullVoxPopuli
Copy link
Contributor

@NullVoxPopuli NullVoxPopuli commented Apr 16, 2022

All the context here: emberjs/ember-cli-babel#441

To test if this actually solves the above:
Repro of emberjs/ember-cli-babel#441: https://github.com/NullVoxPopuli/repo-repro-ember-cli-babel-441

  • run yarn

Separate Terminal

  • checkout this branch for ember-rfc176-data
  • yarn
  • yarn link

Back in the other terminal

  • yarn link "ember-rfc176-data"
  • ember test
    See:
{"type":"error","text":"Uncaught ReferenceError: deprecate is not defined at http://localhost:7357/assets/my-app-test-deprecate.js, line 28\n","testContext":{}}

Which is actually no different from pre-this change. I need to pair this with seeing if Ember.deprecate exists. Stand by.


update, it does:
image

So... more debugging. sorry for the noise -- if anyone can convert this to draft before I finish debugging, that'd be much appreciate (also, why does github not allow me to do this to my own PRs?)

@NullVoxPopuli
Copy link
Contributor Author

Going to continue investigation on the babel issue, as I'm re-starting from the app->down

@rwjblue rwjblue added the bug label Jan 18, 2023
@rwjblue rwjblue merged commit 3de99fb into ember-cli:master Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants