Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove requirement to have dependency managers. #143

Merged
merged 2 commits into from Nov 2, 2020
Merged

Remove requirement to have dependency managers. #143

merged 2 commits into from Nov 2, 2020

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented Aug 8, 2017

Fixes #81

@rwjblue rwjblue mentioned this pull request Aug 8, 2017
Closed
trentmwillis
trentmwillis reviewed Aug 8, 2017
View reviewed changes
Copy link
Member

@trentmwillis trentmwillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is about what I had in mind when I originally opened the issue. Was unsure though if this.dependencyManagerAdapters would need to at least be initialized to some value (seems like a test for this case may be worthwhile?)

@rwjblue
Copy link
Member Author

rwjblue commented Aug 8, 2017

Agreed. I'll add a test for it.

dependencyManagerAdapters is initialized to an empty array in DependencyManagerAdapterFactory.generateFromConfig, so I do not think we need to guard against undefined.

@kategengler kategengler mentioned this pull request May 19, 2018
Closed
@rwjblue rwjblue force-pushed the remove-dependency-manager-requirement branch from 52725c6 to 2157e49 Compare November 2, 2020 15:14
@rwjblue rwjblue merged commit 49d304e into master Nov 2, 2020
@rwjblue rwjblue deleted the remove-dependency-manager-requirement branch November 2, 2020 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trentmwillis trentmwillis trentmwillis left review comments

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow scenarios without dependency changes
2 participants
@rwjblue @trentmwillis