Ensure Yarn Workspace adapter supports ember try:reset.
#467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fundamentally, `Adapter.prototype.cleanup` **cannot** require `Adatper.prototype.setup` to have been called. _Most_ of the time `.setup` is called before `.cleanup` (this happens with `ember try:each` and `ember try:one`), but when `--skip-cleanup` is specified (e.g. `ember try:one scenario-name --skip-cleanup`) and you subsequently run `ember try:reset` the `.setup` happened in a completely different process. The issue here is a misunderstanding when we added the `WorkspaceAdapter` initially. Basically, the assumtion was that `.setup` was for setting up both local instance state (e.g. the `this._packageAdapters` array) **and** for actually preparing for a `ember try:...` run (doing backups / etc). The fix is to move the internal state setup code directly into `init`/`constructor, and ensure that `.setup` is only used to create the backups themselves.
rwjblue
force-pushed
the
ensure-workspace-supports-reset
branch
from
a82fc08
to
7648b01
Compare
Codecov Report
@@ Coverage Diff @@
## master #467 +/- ##
=======================================
Coverage 96.91% 96.91%
=======================================
Files 17 17
Lines 584 584
=======================================
Hits 566 566
Misses 18 18
Continue to review full report at Codecov.
|
BarryThePenguin
approved these changes
Mar 12, 2020
kategengler
approved these changes
Mar 12, 2020
|
Works well now, thank you 👏 |
|
@rwjblue @kategengler Any chance of a new release to include the changes in this PR? 🙏 We're keen to upgrade from 3.12 LTS to 3.16 LTS, and we'd like to have |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fundamentally,
Adapter.prototype.cleanupcannot requireAdatper.prototype.setupto have been called. Most of the time.setupis called before.cleanup(this happens withember try:eachandember try:one), but when--skip-cleanupis specified (e.g.ember try:one scenario-name --skip-cleanup) and you subsequently runember try:resetthe.setuphappened in a completely different process.The issue here is a misunderstanding when we added the
WorkspaceAdapterinitially. Basically, the assumtion was that.setupwas for setting up both local instance state (e.g. thethis._packageAdaptersarray) and for actually preparing for aember try:...run (doing backups / etc).The fix is to move the internal state setup code directly into
init/constructor, and ensure that.setup` is only used to create the backups themselves.Fixes #466