Use matrix builds to speed up all commands smoke tests #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
force-pushed
the
rwjblue/parallelize-smoke-tests
branch
3 times, most recently
from
bef4dd3
to
a783c06
Compare
This allows us to remove hte custom `npm pack` work that was being done in `run-smoke-test.sh` and simplify the testing of the smoke-test-app.
rwjblue
force-pushed
the
rwjblue/parallelize-smoke-tests
branch
from
a783c06
to
6dd5973
Compare
kategengler
reviewed
Oct 29, 2020
package.json
Outdated
| "lint": "eslint lib test", | ||
| "lint:hbs": "ember-template-lint .", | ||
| "lint:js": "eslint .", | ||
| "node-test": "mocha test/**/*.js", | ||
| "node-test-with-coverage": "nyc --reporter lcov npm run-script node-test && node_modules/.bin/codecov", | ||
| "smoke-test": "./run-smoke-test.sh smoke-test.sh", | ||
| "smoke-test-yarn": "./run-smoke-test.sh smoke-test-yarn.sh", | ||
| "smoke-test": "cd smoke-test-app && ./smoke-test.sh", |
There was a problem hiding this comment.
I think these scripts are "weird" now locally because unless you've gone into smoke-test-app and installed with the correct package manager, you can easily run smoke-test-yarn and have it being using npm, and vice versa.
There was a problem hiding this comment.
I just decided to delete these scripts all together. I couldn't think of a way to ensure they actually run in the right contexts, and since CI is actually pretty fast / peppy it's probably fine...
kategengler
approved these changes
Oct 29, 2020
rwjblue
force-pushed
the
rwjblue/parallelize-smoke-tests
branch
from
762a571
to
0c6f226
Compare
rwjblue
force-pushed
the
rwjblue/parallelize-smoke-tests
branch
2 times, most recently
from
86ad8d0
to
3e8a476
Compare
rwjblue
force-pushed
the
rwjblue/parallelize-smoke-tests
branch
from
3e8a476
to
8947601
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of running a single shell script, run a job for each of the individual commands. This will result in many more CI jobs, but should be much much faster total time.