Use ember-addon.configPath from package.json if defined.
#585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes `ember-try` work much closer to how other ecosystem tools work (`@ember/optional-features`, `ember-cli`'s lookup of `config/environment.js` and `config/targets.js`, `ember-cli-code-coverage`). This is not a breaking change, as it still falls back to using the older hardcoded `config/ember-try.js` path.
delete-merged-branch
bot
deleted the
use-custom-config-path-if-defined
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes
ember-trywork much closer to how other ecosystem tools work (@ember/optional-features,ember-cli's lookup ofconfig/environment.jsandconfig/targets.js,ember-cli-code-coverage).This is not a breaking change, as it still falls back to using the older hardcoded
config/ember-try.jspath.Fixes #305