Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump json from 10.0.0 to 11.0.0 #755

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 2, 2021

Bumps json from 10.0.0 to 11.0.0.

Changelog

Sourced from json's changelog.

11.0.0

  • Backward incompatible and security-related change to parsing the -d DELIM option. (#148)

    The -d DELIM option allows specifying the field delimiter in output:

      % echo '{"name":"trent","age":38}' | json -a name age
      trent 38
      % echo '{"name":"trent","age":38}' | json -a name age -d,
      trent,38
    

    The given "DELIM" string is parsed to allow escapes. For example:

      % echo '{"name":"trent","age":38}' | json -a name age -d'\t'
      trent	38
      % echo '{"name":"trent","age":38}' | json -a name age -d'\n'
      trent
      38
    

    Before this change, that parsing used eval(), which allowed for unintended code execution if an untrusted argument to -d was provided. The fix for this vulnerability changes to use JSON.parse() to support escapes. However that results in a backward incompatible change, because the set of JSON escapes is a subset of JavaScript escapes.

    The only escape I expect that would affect any current user would be the null byte escape (\0) which can be useful for processing values that may have spaces or other likely delimiter characters. For example:

      # BEFORE
      % echo '{"title":"Monsters, Inc.","year":"2001"}' \
        | json -a title year -d'\0' \
        | xargs -0 node -e 'console.log(process.argv)'
      [ 'node', 'Monsters, Inc.', '2001\n' ]
    

    AFTER

    % echo '{"title":"Monsters, Inc.","year":"2001"}' | json -a title year -d'\0' json: error: Unexpected number in JSON at position 2

    One must now use the JSON unicode escape syntax, '\u0000':

      % echo '{"title":"Monsters, Inc.","year":"2001"}' \
        | json -a title year -d'\u0000' \
        | xargs -0 node -e 'console.log(process.argv)'
      [ 'node', 'Monsters, Inc.', '2001\n' ]
    
Commits
  • e08c868 11.0.0
  • 0672aad fix test suite for new '-d DELIM' tests for node >=12
  • 4a69ea3 doc, fix tests, and improve errors for '-d DELIM' change in #150
  • 4114e32 Fix Code injection in -d DELIM through use of eval (#150)
  • 27e1ad7 update devDeps to latest version; regen 'json_parse' with latest uglify-js ve...
  • ffeaab4 bump semver (#137) and fix tools/perf.js
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Oct 2, 2021
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/json-11.0.0 branch 3 times, most recently from 6a59659 to 3da10f3 Compare October 5, 2021 16:46
Bumps [json](https://github.com/trentm/json) from 10.0.0 to 11.0.0.
- [Release notes](https://github.com/trentm/json/releases)
- [Changelog](https://github.com/trentm/json/blob/master/CHANGES.md)
- [Commits](trentm/json@10.0.0...11.0.0)

---
updated-dependencies:
- dependency-name: json
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/json-11.0.0 branch from 3da10f3 to fa83e84 Compare March 1, 2023 19:12
@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

Merging #755 (d434026) into master (17592f8) will not change coverage.
The diff coverage is n/a.

❗ Current head d434026 differs from pull request most recent head fa83e84. Consider uploading reports for the commit fa83e84 to get more accurate results

@@           Coverage Diff           @@
##           master     #755   +/-   ##
=======================================
  Coverage   94.36%   94.36%           
=======================================
  Files          17       17           
  Lines         550      550           
=======================================
  Hits          519      519           
  Misses         31       31           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

0 participants