Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Node.js 14 support #920

Merged
merged 12 commits into from Aug 15, 2023
Merged

Conversation

SergeAstapov
Copy link
Contributor

Follow up to #913

Copy link
Contributor

@hjdivad hjdivad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you look into the failing tests

As in #913 the floating deps test is expected to fail, but the rest should be green.

@hjdivad
Copy link
Contributor

hjdivad commented Mar 2, 2023

@SergeAstapov

@SergeAstapov
Copy link
Contributor Author

@hjdivad it seems never version of npm bundled with Node.js 16 cause a hard error because ember-try-test-suite-helper@0.0.1 specific here actually does not exist on npm (only 1.0.0 and 1.0.1 have been published)

it seems more correctly to actually publish that version to npm, wonder if @kategengler can do so.

meanwhile I'll try to look if there is something else missing or I can came up with a workaround

@mansona
Copy link
Member

mansona commented Mar 3, 2023

Hey folks 👋 #893 has CI passing and works around that problem you also identified @SergeAstapov

@mansona mansona force-pushed the drop-node-14 branch 2 times, most recently from 7d737aa to cdabdf5 Compare June 28, 2023 16:00
@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Merging #920 (496d0cf) into master (c92dc69) will increase coverage by 0.04%.
The diff coverage is 100.00%.

❗ Current head 496d0cf differs from pull request most recent head 54f68f5. Consider uploading reports for the commit 54f68f5 to get more accurate results

@@            Coverage Diff             @@
##           master     #920      +/-   ##
==========================================
+ Coverage   94.54%   94.59%   +0.04%     
==========================================
  Files          17       17              
  Lines         550      555       +5     
==========================================
+ Hits          520      525       +5     
  Misses         30       30              
Files Changed Coverage Δ
smoke-test-app/tests/dummy/config/ember-try.js 100.00% <ø> (ø)
lib/dependency-manager-adapters/npm.js 98.41% <100.00%> (+0.06%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@kategengler kategengler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested from @mansona

lib/dependency-manager-adapters/npm.js Show resolved Hide resolved
lib/dependency-manager-adapters/npm.js Show resolved Hide resolved
@kategengler
Copy link
Member

Thank you!!

@kategengler kategengler merged commit 9d9763a into ember-cli:master Aug 15, 2023
30 checks passed
@SergeAstapov SergeAstapov deleted the drop-node-14 branch August 16, 2023 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants