Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update smoke test to fix CI #933

Merged
merged 3 commits into from Mar 23, 2023
Merged

Conversation

mansona
Copy link
Member

@mansona mansona commented Mar 22, 2023

This is required because ember-canary was throwing errors now that @ember/string has been removed

@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Merging #933 (a3399a2) into master (4c675cf) will not change coverage.
The diff coverage is n/a.

❗ Current head a3399a2 differs from pull request most recent head 7cabca0. Consider uploading reports for the commit 7cabca0 to get more accurate results

@@           Coverage Diff           @@
##           master     #933   +/-   ##
=======================================
  Coverage   94.36%   94.36%           
=======================================
  Files          17       17           
  Lines         550      550           
=======================================
  Hits          519      519           
  Misses         31       31           
Impacted Files Coverage Δ
smoke-test-app/tests/dummy/config/ember-try.js 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mansona mansona merged commit 4540780 into ember-cli:master Mar 23, 2023
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants