Use pnpm's --no-lockfile #960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #960 +/- ##
=======================================
Coverage 94.54% 94.54%
=======================================
Files 17 17
Lines 550 550
=======================================
Hits 520 520
Misses 30 30
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
kategengler
reviewed
Jul 12, 2023
README.md
Outdated
| @@ -121,7 +121,7 @@ module.exports = async function() { | |||
| */ | |||
| useYarn: true, | |||
| /* | |||
| If set to true, all npm scenarios will use `pnpm` for install with the `--frozen-lockfile=false` option. At cleanup, your | |||
| If set to true, all npm scenarios will use `pnpm` for install with the `--frozen-lockfile=false --no-lockfile` options. At cleanup, your | |||
There was a problem hiding this comment.
Is --frozen-lockfile=false necessary when using --no-lockfile?
There was a problem hiding this comment.
Testing here:
- with: 🟢 https://github.com/NullVoxPopuli/ember-cli-pnpm-ember-try-test-lockfile-options/actions/runs/5543210214
- without: 🟢 https://github.com/NullVoxPopuli/ember-cli-pnpm-ember-try-test-lockfile-options/actions/runs/5543250623
-frozen-lockfile=false has been removed
🥳
idk why I thought they'd both be needed 🙃
NullVoxPopuli
added a commit
to NullVoxPopuli/ember-cli-pnpm-ember-try-test-lockfile-options
that referenced
this pull request
Jul 13, 2023
|
Thank you! |
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous try-hard attempt here: https://github.com/ember-cli/ember-try/pull/958/files
(lesson for me, don't trust any web site ever, always check
--help)