Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the system's temp folder for backing up package-manager files #965

Conversation

bertdeblock
Copy link

@bertdeblock bertdeblock commented Sep 6, 2023

Builds on #964, so should be reviewed and merged first.

Closes #599.

@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Merging #965 (ed50a70) into master (f68085c) will increase coverage by 0.21%.
The diff coverage is 100.00%.

❗ Current head ed50a70 differs from pull request most recent head 01c179e. Consider uploading reports for the commit 01c179e to get more accurate results

@@            Coverage Diff             @@
##           master     #965      +/-   ##
==========================================
+ Coverage   94.38%   94.59%   +0.21%     
==========================================
  Files          17       18       +1     
  Lines         534      518      -16     
==========================================
- Hits          504      490      -14     
+ Misses         30       28       -2     
Files Changed Coverage Δ
lib/dependency-manager-adapters/npm.js 97.59% <100.00%> (-0.51%) ⬇️
lib/dependency-manager-adapters/pnpm.js 90.47% <100.00%> (+0.11%) ⬆️
lib/utils/backup.js 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bertdeblock bertdeblock force-pushed the use-system-temp-for-backing-up-package-manager-files branch 3 times, most recently from 87d81ac to 3ca9621 Compare September 6, 2023 12:23
@bertdeblock bertdeblock marked this pull request as ready for review September 6, 2023 12:48
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@NullVoxPopuli NullVoxPopuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a very welcomed refactor <3

README.md Outdated Show resolved Hide resolved
@bertdeblock bertdeblock force-pushed the use-system-temp-for-backing-up-package-manager-files branch from 77eb7f8 to 01c179e Compare September 6, 2023 19:11
@bertdeblock bertdeblock changed the title Use the system temp's folder for backing up package-manager files Use the system's temp folder for backing up package-manager files Sep 7, 2023
@bertdeblock bertdeblock merged commit 2438dca into ember-cli:master Sep 7, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move backups to system tmp directory (instead of in project)
3 participants