fix: crash with this.extend() in no-classic-classes rule

ember-cli · Mar 9, 2021 · 0f8778e · 0f8778e
1 parent ec54b86
commit 0f8778e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/lib/rules/no-classic-classes.js b/lib/rules/no-classic-classes.js
@@ -59,7 +59,10 @@ module.exports = {
         // Invalid if there are no arguments because that is equivalent to not called `extend` at all
         // Invalid with an object as an argument because that logic needs conversion to a native class
         // Still allows `.extend` if some other identifier is passed, like a Mixin
-        if (hasNoArguments(callExpression) || hasObjectArgument(callExpression)) {
+        if (
+          (hasNoArguments(callExpression) || hasObjectArgument(callExpression)) &&
+          ['Identifier', 'MemberExpression'].includes(node.object.type)
+        ) {
           const classImportedFrom = getSourceModuleNameForIdentifier(context, node.object);
           if (isEmberImport(classImportedFrom)) {
             reportNode(callExpression);

diff --git a/tests/lib/rules/no-classic-classes.js b/tests/lib/rules/no-classic-classes.js
@@ -35,6 +35,7 @@ ruleTester.run('no-classic-classes', rule, {
       export default SomeOtherThing.extend({});
     `,
     'export default Component.extend({});', // No import
+    "import thing from 'place'; this.extend();",
   ],
 
   invalid: [