Fix crash with default computed property import in `no-unused-service…

…s` rule (#1870)
ember-cli · May 21, 2023 · 3f9a95f · 3f9a95f
1 parent 71be77f
commit 3f9a95f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/lib/rules/no-unused-services.js b/lib/rules/no-unused-services.js
@@ -130,6 +130,9 @@ module.exports = {
         }
         if (node.source.value === '@ember/object/computed') {
           for (const spec of node.specifiers) {
+            if (spec.type === 'ImportDefaultSpecifier') {
+              continue;
+            }
             const name = spec.imported.name;
             if (macros.includes(name)) {
               const localName = spec.local.name;

diff --git a/tests/lib/rules/no-unused-services.js b/tests/lib/rules/no-unused-services.js
@@ -187,6 +187,7 @@ ruleTester.run('no-unused-services', rule, {
     `${SERVICE_IMPORT} class MyClass {}`,
     `${SERVICE_IMPORT} Component.extend({});`,
     'const foo = service();',
+    "import ComputedProperty from '@ember/object/computed';",
   ],
   invalid: [
     {