refactor: remove other unused code

ember-cli · Nov 21, 2019 · bb09420 · bb09420
1 parent f0f0228
commit bb09420
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 16 deletions.
diff --git a/lib/rules/require-computed-macros.js b/lib/rules/require-computed-macros.js
@@ -30,10 +30,6 @@ const ERROR_MESSAGE_EQUAL = makeErrorMessage('equal');
  * @returns {boolean} Whether the node looks like `this.x && this.y && this.z` or `this.get('x') && this.get('y') && this.get('z')`.
  */
 function isSimpleThisExpressionsInsideLogicalExpression(node, operator) {
-  if (!types.isLogicalExpression(node)) {
-    return false;
-  }
-
   let current = node;
   while (current !== null) {
     if (types.isLogicalExpression(current)) {

diff --git a/lib/utils/types.js b/lib/utils/types.js
@@ -13,7 +13,6 @@ module.exports = {
   isConciseArrowFunctionWithCallExpression,
   isConditionalExpression,
   isDecorator,
-  isExpressionStatement,
   isFunctionDeclaration,
   isFunctionExpression,
   isIdentifier,
@@ -176,16 +175,6 @@ function isDecorator(node) {
   return node !== undefined && node.type === 'Decorator';
 }
 
-/**
- * Check whether or not a node is an ExpressionStatement.
- *
- * @param {Object} node The node to check.
- * @returns {boolean} Whether or not the node is an ExpressionStatement.
- */
-function isExpressionStatement(node) {
-  return node !== undefined && node.type === 'ExpressionStatement';
-}
-
 /**
  * Check whether or not a node is a FunctionDeclaration
  *

diff --git a/lib/utils/utils.js b/lib/utils/utils.js
@@ -210,7 +210,6 @@ function getSourceModuleName(node) {
       false,
       '`getSourceModuleName` should only be called on `MemberExpression` or `Identifier`'
     );
-    return undefined;
   }
 }