Fix crash in jquery-ember-run rule
#1431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The included test demonstrates a case that would trigger an assertion within eslint. It's not correct to try to `report(expression.callee)` without asserting that the expression is a CallExpression. Lots of other kinds of nodes can appear here instead, and the AssignmentExpression in my example is only one of the possibilities. The refactoring into two helper functions here was forced by the complexity eslint rule this repo uses.
bmish
changed the title
jquery-ember-run rule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The included test demonstrates a case that would trigger an assertion within eslint.
It's not correct to try to
report(expression.callee)without checking first that the expression is a CallExpression. Lots of other kinds of nodes can appear here instead, and they will cause us to pass undefined toreport(), which generates the assertion within eslint.The refactoring into two helper functions here was forced by the complexity eslint rule this repo uses.