Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch replace in no-array-prototype-extensions rule #1476

Merged

Conversation

smilland
Copy link
Contributor

@smilland smilland commented May 4, 2022

Catch replace as part of no-array-prototype-extensions. Previously we skipped as it's also part of String.prototype, we can still differentiate them by checking arguments length.

String.prototype.replace()

Array.prototype.replace()

@bmish bmish added the Bug label May 4, 2022
@bmish bmish changed the title Support replace in no-array-prototype-extensions Catch replace in no-array-prototype-extensions rule May 4, 2022
Copy link
Member

@bmish bmish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bmish bmish merged commit fc81768 into ember-cli:master May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants