Fix some crashes including with legacy classes in no-deprecated-router-transition-methods and no-implicit-injections rules
#1722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After configuring on another one of our projects I've found some more bugs. Adding tests and working on them now |
rtablada
commented
Jan 2, 2023
| (serviceExpression.arguments.length > 0 && | ||
| serviceExpression.arguments[0].value === 'router') | ||
| ) { | ||
| if (serviceInjectImportName) { |
There was a problem hiding this comment.
Without this if statement, if inject service wasn't imported: then any property would have been checked/considered as being a service.
bmish
changed the title
no-deprecated-router-transition-methods and no-implicit-injections rules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying the latest version with updated rules, I found there were issues with the two deprecation rules when used with some more obscure legacy Ember object patterns.
I added tests that would fail on the main branch lib code and updated lib to suit.
Fixes #1728.