Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix setup for eslint-remote-tester for testing our rules against other repos #1741

Merged
merged 5 commits into from
May 21, 2023
Merged

Fix setup for eslint-remote-tester for testing our rules against other repos #1741

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
569563d
chore: tweak setup for eslint-remote-tester
bmish Jan 10, 2023
3155ee9
Merge branch 'master' into tweak-eslint-remote-tester
bmish Jan 16, 2023
1357d67
Merge branch 'master' into tweak-eslint-remote-tester
bmish May 21, 2023
ef433f6
Merge branch 'master' into tweak-eslint-remote-tester
bmish May 21, 2023
d45ffe7
Merge branch 'master' into tweak-eslint-remote-tester
bmish May 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,4 @@ npm-debug.log
.vscode

# eslint-remote-tester
.cache-eslint-remote-tester
eslint-remote-tester-results
13 changes: 9 additions & 4 deletions eslint-remote-tester.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/* eslint filenames/match-regex:off */
const { getPathIgnorePattern } = require('eslint-remote-tester-repositories');
const fs = require('fs');

/** @type {import('eslint-remote-tester').Config} */
module.exports = {
/** Repositories to scan */
repositories: [
Expand All @@ -28,9 +28,6 @@ module.exports = {
'typed-ember/ember-cli-typescript',
],

/** Optional pattern used to exclude paths */
pathIgnorePattern: getPathIgnorePattern(),

/** Extensions of files under scanning */
extensions: ['js', 'ts'],

Expand All @@ -40,6 +37,7 @@ module.exports = {
/** ESLint configuration */
eslintrc: {
plugins: ['ember'],

// Enable all of our rules.
rules: Object.fromEntries(
fs
Expand All @@ -58,5 +56,12 @@ module.exports = {
return [ruleName, value];
})
),

overrides: [
{
files: ['*.ts'],
parser: '@typescript-eslint/parser',
},
],
},
};
1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,6 @@
"eslint-plugin-prettier": "^4.0.0",
"eslint-plugin-unicorn": "^46.0.0",
"eslint-remote-tester": "^3.0.0",
"eslint-remote-tester-repositories": "^1.0.0",
"jest": "^29.1.2",
"jquery": "^3.5.1",
"jsdom": "^21.0.0",
Expand Down
5 changes: 0 additions & 5 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2911,11 +2911,6 @@ eslint-plugin-unicorn@^46.0.0:
semver "^7.3.8"
strip-indent "^3.0.0"

eslint-remote-tester-repositories@^1.0.0:
version "1.0.1"
resolved "https://registry.yarnpkg.com/eslint-remote-tester-repositories/-/eslint-remote-tester-repositories-1.0.1.tgz#2e5f15fa6bb631e72e817772867ff6771ed20b51"
integrity sha512-XL9PqGBDL4rORnQ74b/3tqbJUpMlPz9gzKSrmYFtakLBQ/ayBELB/HZvd6ZEl+mH0vBeSYtUH7E/rawBsf9Qzg==

eslint-remote-tester@^3.0.0:
version "3.0.0"
resolved "https://registry.yarnpkg.com/eslint-remote-tester/-/eslint-remote-tester-3.0.0.tgz#aa9b357d65250245f1d6556b4decaf993e2c72f4"
Expand Down