Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getProperties autofixer to no-get rule #1823

Merged
merged 3 commits into from Apr 5, 2023

Conversation

ArtixZ
Copy link
Contributor

@ArtixZ ArtixZ commented Apr 2, 2023

Fixes #1821
Add support for auto-fixing getProperties in no-get rule.
Tests are added.

@bmish bmish changed the title getProperties auto-fix Add getProperties autofixer to no-get rule Apr 2, 2023
Copy link
Member

@bmish bmish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

lib/rules/no-get.js Outdated Show resolved Hide resolved
lib/rules/no-get.js Outdated Show resolved Hide resolved
lib/rules/no-get.js Show resolved Hide resolved
@ArtixZ ArtixZ requested a review from bmish April 4, 2023 00:51
Copy link
Member

@bmish bmish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Excited to see this new autofixer.

@bmish bmish merged commit e497078 into ember-cli:master Apr 5, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add no-get rule autofixer for getProperties
2 participants