Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add requireArgs option in require-super-in-lifecycle-hooks rule #1836

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Add requireArgs option in require-super-in-lifecycle-hooks rule #1836

wants to merge 6 commits into from

Commits on Apr 17, 2023

  1. make sure the init hook is called with arguments

    samridhi committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    4d79934 View commit details
    Browse the repository at this point in the history

  2. add some test cases

    samridhi committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    ef63805 View commit details
    Browse the repository at this point in the history

  3. fix bug in hasSuperWithArguments logic

    samridhi committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    a151791 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2023

  1. add requireArgs option

    samridhi committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    14a5398 View commit details
    Browse the repository at this point in the history

  2. update documentation with the new requireArgs option

    samridhi committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    088a404 View commit details
    Browse the repository at this point in the history

  3. resolve PR feeback

    samridhi committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    c922dc3 View commit details
    Browse the repository at this point in the history