Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid crash with inject decorator in no-restricted-service-injections rule #1869

Merged
merged 1 commit into from May 21, 2023

Conversation

bmish
Copy link
Member

@bmish bmish commented May 21, 2023

Crash detected by:

Rule: "ember/no-restricted-service-injections"
Path: emberjs/data/tests/main/app/routes/application.ts
Link: https://github.com/emberjs/data/blob/HEAD/tests/main/app/routes/application.ts#L7

   5 |
   6 | export default class ApplicationRoute extends Route {
>  7 |   @inject declare store: Store;
   8 |
   9 |   model() {
  10 |     // adding a model to the store to enable manually testing the debug-adapter

Error:
TypeError: Cannot read property 'expression' of undefined
Occurred while linting /home/runner/work/eslint-plugin-ember/eslint-plugin-ember/node_modules/eslint-remote-tester/.cache-eslint-remote-tester/emberjs/data/tests/main/app/routes/application.ts:7

Related:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant