Check template tags for service usages in no-unused-services
#1899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bmish bug fix or enhancement? 🤔 |
|
@chrisrng fyi |
added 2 commits
June 25, 2023 20:29
bmish
approved these changes
Jun 26, 2023
chrisrng
reviewed
Jun 26, 2023
| @@ -170,7 +172,22 @@ module.exports = { | |||
| return; | |||
| } | |||
|
|
|||
| if ( | |||
| if (node.callee.name === TEMPLATE_TAG_PLACEHOLDER) { | |||
There was a problem hiding this comment.
Should we make this into a common util? Seems like something most rules will start needing to know about
(Can always do it when the 2nd use case shows up)
There was a problem hiding this comment.
Good point! I'll wait for the next case to show up -- I'm sure there are things with the recast parsing that can be extracted out cleverly too, but I think it would be helpful to see some more usages of it first in order to know what common patterns people use.
chrisrng
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With template imports, we need to check template tags for usages of services. Otherwise,
no-unused-serviceswill have false positives.I brought it
ember-template-recastto parse the AST for the template tag. Is this how we want to do this moving forward? If not, suggestions are welcome.