Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for Node 14, 16, 19 #1962

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Drop support for Node 14, 16, 19 #1962

merged 1 commit into from
Oct 31, 2023

Conversation

patricklx
Copy link
Contributor

@patricklx patricklx commented Oct 31, 2023 •
edited by bmish

#1535
also, took this change to switch to eslint plugin n

  • Drop Node 14 (EOL April 2023)
  • Drop Node 16 (EOL Sep 2023)
  • Drop Node 19 (EOL June 2023)

@NullVoxPopuli NullVoxPopuli changed the title prepare v12 - drop nodes drop nodes < 18 Oct 31, 2023
@NullVoxPopuli
Copy link
Contributor

Thank you!

@NullVoxPopuli NullVoxPopuli merged commit abb61e0 into ember-cli:master Oct 31, 2023
8 checks passed
@bmish
Copy link
Member

bmish commented Oct 31, 2023

Can you please drop Node 19 as well?

@patricklx
Copy link
Contributor Author

patricklx commented Oct 31, 2023 •
edited

Node 19 is excluded.
according to https://nodejs.org/en/about/previous-releases 18.x is LTS... strangly 19 isnt.
edit: ah, odd-numbered do not get lts...

@bmish
Copy link
Member

bmish commented Oct 31, 2023

Okay nevermind looks good. Could have simplified to 18.* || >=20 but what you have is fine.

@NullVoxPopuli NullVoxPopuli changed the title drop nodes < 18 drop node 19 and nodes < 18 Oct 31, 2023
@bmish bmish changed the title drop node 19 and nodes < 18 Drop Node 14, 16, 19 Oct 31, 2023
@bmish bmish changed the title Drop Node 14, 16, 19 Drop support for Node 14, 16, 19 Oct 31, 2023
This was referenced Oct 31, 2023
Closed
Merged
@MrChocolatine MrChocolatine mentioned this pull request Feb 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Breaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@patricklx @NullVoxPopuli @bmish