[gjs/gts parser] fix references for tags with a dot & non standard html tags #1992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patricklx
changed the title
| @@ -260,6 +261,34 @@ function preprocessGlimmerTemplates(info, code) { | |||
| n.loc.start = codeLines.offsetToPosition(tpl.templateRange[0]); | |||
| n.loc.end = codeLines.offsetToPosition(tpl.templateRange[1]); | |||
| } | |||
| // split up element node into sub nodes to be able to reference tag name | |||
| // parts <Foo.Bar /> -> nodes for `Foo` and `Bar` | |||
| if (n.type === 'ElementNode') { | |||
There was a problem hiding this comment.
Shouldn't this be @glimmer/syntax responsibility?
There was a problem hiding this comment.
i think it should, yes.
same for block params, there is no node for them
There was a problem hiding this comment.
Excellent, can you open an issue over on glimmer-vm?
Once we get that shipped, we can clean up here
NullVoxPopuli
approved these changes
Nov 9, 2023
|
@patricklx let's mention "gjs/gts parser" in the title of these PRs so users have the relevant context to understand which part of eslint-plugin-ember these PRs are affecting. |
patricklx
changed the title
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1991