Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gjs/gts parser] fix locations for ast after templates #1994

Merged
merged 2 commits into from
Nov 9, 2023
Merged

[gjs/gts parser] fix locations for ast after templates #1994

merged 2 commits into from
Nov 9, 2023

Conversation

patricklx
Copy link
Contributor

@patricklx patricklx commented Nov 9, 2023 •
edited

fixes #1993

@bmish bmish added the Bug label Nov 9, 2023
@NullVoxPopuli
Copy link
Contributor

Can we add the test case from #1993 ?

@patricklx
Copy link
Contributor Author

patricklx commented Nov 9, 2023 •
edited

Can we add the test case from #1993 ?

thats what i did :)
or rather replaced correctly maps duplicate <template> tokens to the correct lines with it

NullVoxPopuli
NullVoxPopuli approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@NullVoxPopuli NullVoxPopuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, i see what was fixed now. Thanks!

@NullVoxPopuli NullVoxPopuli merged commit 3ec4b26 into ember-cli:master Nov 9, 2023
8 checks passed
@patricklx patricklx changed the title fix locations for ast after templates [gjs/gts parser] fix locations for ast after templates Nov 9, 2023
@vstefanovic97
Copy link

can we release new alpha version with this fix?

@patricklx patricklx deleted the fix-locations branch November 10, 2023 17:02
@bmish
Copy link
Member

bmish commented Nov 11, 2023

https://github.com/ember-cli/eslint-plugin-ember/releases/tag/v12.0.0-alpha.2

@NullVoxPopuli NullVoxPopuli mentioned this pull request Dec 12, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NullVoxPopuli NullVoxPopuli NullVoxPopuli approved these changes

Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gjs/gts Incorrect token mapping after handlebars
4 participants
@patricklx @NullVoxPopuli @vstefanovic97 @bmish