[gjs-gts-parser] fix parsing when there are multiple default <template> blocks (not allowed)
#2005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you provide some context about this in the PR description? |
| @@ -91,6 +91,10 @@ const valid = [ | |||
| <template> | |||
| <div {{on 'click' noop}} /> | |||
| </template> | |||
|
|
|||
| <template> | |||
| <div {{on 'click' noop}} /> | |||
There was a problem hiding this comment.
@bmish this is the bad code -- can't have two default templates
There was a problem hiding this comment.
@bmish it would have failed to parse it without this change
There was a problem hiding this comment.
Can you provide some context about the actual fix too? What was wrong before and how does your change fix it?
There was a problem hiding this comment.
Before i would have converted the template parts to template string literals.
`
Tpl1
`
`
Tpl2
`But that makes it one tagged template literal... Instead of 2 separates.
Now i make them tagged already.
""
`
Tpl1
`
""
`
Tpl2
`I use string as tag name, as otherwise eslint would complain about missing references to identifiers
NullVoxPopuli
changed the title
NullVoxPopuli
approved these changes
Nov 21, 2023
patricklx
changed the title
2 tasks
bmish
added a commit
to bmish/eslint-plugin-ember
that referenced
this pull request
Dec 12, 2023
* master: (46 commits) fix gts type aware by emulating them to ts files set our own ts.sys with ts.setSys typescript-eslint has handling for a lot of scenarios for file changes and project changes etc use mts extension to keep same offsets we also sync the mts with the gts files Switch to ESLint flat config internally (ember-cli#2018) [gjs-gts-parser] fix parsing when there are multiple default <template> blocks (not allowed) (ember-cli#2005) Release 12.0.0-alpha.2 fix locations after template reference tag name parts (split up with dot) instead of whole tag add failing test Release 12.0.0-alpha.1 docs: recommended-gts/gjs instead of gts/gjs-recommended add rule to gjs & gts build(deps-dev): Bump eslint from 8.52.0 to 8.53.0 build(deps-dev): Bump npm-package-json-lint from 7.0.0 to 7.1.0 build(deps-dev): Bump eslint-doc-generator from 1.5.3 to 1.5.4 Update `@typescript-eslint/` dependencies to v6 (ember-cli#1984) Fix missing gjs/cts config icons (ember-cli#1982) improve gts gjs configuration example Release 12.0.0-alpha.0 Switch to `@release-it-plugins/lerna-changelog` (ember-cli#1979) Set config `ecmaVersion` to `2022` (ember-cli#1978) Add new `recommended` rule: `template-no-let-reference` (ember-cli#1977) ...
bmish
changed the title
<template> blocks (not allowed)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered this while working on implementing content-tag for prettier plugin, which has tests for multiple default templates.
It would fail to parse the file in that case.
Before i would have converted the template parts to template string literals.
But that makes it one tagged template literal... Instead of 2 separates.
Now i make them tagged already.
I use string as tag name, as otherwise eslint would complain about missing references to identifiers