Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to ESLint flat config internally #2018

Merged
merged 1 commit into from
Dec 9, 2023
Merged

Conversation

bmish
Copy link
Member

@bmish bmish commented Dec 8, 2023

This converts to the new ESLint flat config internally (will be the default config format in ESLint v9). It does not cause any behavior change internally or externally. We still need to publicly support ESLint flat config after this.

Took some inspiration from:

Relevant info:

@bmish bmish added the Internal label Dec 8, 2023
@bmish bmish changed the title Switch to eslint flat config internally Switch to ESLint flat config internally Dec 8, 2023
@bmish bmish force-pushed the flat-config-1 branch 3 times, most recently from 8a62357 to 58cac04 Compare December 8, 2023 22:31
@bmish bmish marked this pull request as ready for review December 8, 2023 22:36
Copy link
Contributor

@NullVoxPopuli NullVoxPopuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice

@bmish bmish force-pushed the flat-config-1 branch 3 times, most recently from 7f81c71 to 97a2be8 Compare December 9, 2023 16:49
@bmish bmish merged commit 186376c into ember-cli:master Dec 9, 2023
8 checks passed
bmish added a commit to bmish/eslint-plugin-ember that referenced this pull request Dec 12, 2023
* master: (46 commits)
  fix gts type aware by emulating them to ts files set our own ts.sys with ts.setSys typescript-eslint has handling for a lot of scenarios for file changes and project changes etc use mts extension to keep same offsets we also sync the mts with the gts files
  Switch to ESLint flat config internally (ember-cli#2018)
  [gjs-gts-parser] fix parsing when there are multiple default <template> blocks (not allowed) (ember-cli#2005)
  Release 12.0.0-alpha.2
  fix locations after template
  reference tag name parts (split up with dot) instead of whole tag
  add failing test
  Release 12.0.0-alpha.1
  docs: recommended-gts/gjs instead of gts/gjs-recommended
  add rule to gjs & gts
  build(deps-dev): Bump eslint from 8.52.0 to 8.53.0
  build(deps-dev): Bump npm-package-json-lint from 7.0.0 to 7.1.0
  build(deps-dev): Bump eslint-doc-generator from 1.5.3 to 1.5.4
  Update `@typescript-eslint/` dependencies to v6 (ember-cli#1984)
  Fix missing gjs/cts config icons (ember-cli#1982)
  improve gts gjs configuration example
  Release 12.0.0-alpha.0
  Switch to `@release-it-plugins/lerna-changelog` (ember-cli#1979)
  Set config `ecmaVersion` to `2022` (ember-cli#1978)
  Add new `recommended` rule: `template-no-let-reference` (ember-cli#1977)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants