Changes from v11.12.0

CHANGELOG.md

@@ -1,50 +1,3 @@
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
 ## v12.0.0-alpha.2 (2023-11-10)
 
 #### :bug: Bug Fix
@@ -102,6 +55,19 @@
 - Patrick Pircher ([@patricklx](https://github.com/patricklx))
 
 
+## v11.12.0 (2023-12-12)
+
+#### :rocket: Enhancement
+* [#2020](https://github.com/ember-cli/eslint-plugin-ember/pull/2020) Support ESLint flat config ([@bmish](https://github.com/bmish))
+
+#### :bug: Bug Fix
+* [#2027](https://github.com/ember-cli/eslint-plugin-ember/pull/2027) Allow ember-data type registry imports in `use-ember-data-rfc-395-imports` rule ([@wagenet](https://github.com/wagenet))
+
+#### Committers: 2
+- Bryan Mishkin ([@bmish](https://github.com/bmish))
+- Peter Wagenet ([@wagenet](https://github.com/wagenet))
+
+
 ## v11.11.1 (2023-08-22)
 
 #### :bug: Bug Fix

README.md

@@ -25,10 +25,21 @@ Or
 npm install --save-dev eslint-plugin-ember
 ```
 
-### 2. Modify your `.eslintrc.js`
+### 2. Update your config
 
 ```js
-// .eslintrc.js
+// eslint.config.js (flat config)
+const eslintPluginEmberRecommended = require('eslint-plugin-ember/configs/recommended');
+
+module.exports = [
+  ...eslintPluginEmberRecommended,
+];
+```
+
+or
+
+```js
+// .eslintrc.js (legacy config)
 module.exports = {
   plugins: ['ember'],
   extends: [

docs/rules/use-ember-data-rfc-395-imports.md

@@ -14,6 +14,8 @@ The goal of this rule is to ease the migration to the new @ember-data packages.
 
 ember-data has been split in multiple packages. For instance, its store is now released in "@ember-data/store" package. These packages have been released starting from ember-data version 3.11.
 
+For TypeScript users, imports from `ember-data/types/registries/*` are still allowed since there is currently no equivalent in the new packages.
+
 ## Examples
 
 Examples of **incorrect** code for this rule:

lib/config-legacy/base.js

@@ -0,0 +1,27 @@
+module.exports = {
+  root: true,
+
+  parserOptions: {
+    ecmaVersion: 2022,
+    sourceType: 'module',
+  },
+
+  env: {
+    browser: true,
+    es2022: true,
+  },
+
+  plugins: ['ember'],
+
+  overrides: [
+    /**
+     * We don't want to *always* have the preprocessor active,
+     * it's only relevant on gjs and gts files to detect if eslint config is correctly setup for this files.
+     */
+    {
+      files: ['**/*.{gts,gjs}'],
+      parser: 'eslint-plugin-ember/gjs-gts-parser',
+      processor: 'ember/<noop>',
+    },
+  ],
+};

lib/config-legacy/recommended-gjs.js

@@ -0,0 +1,7 @@
+const base = require('./base');
+const gjsRules = require('../recommended-rules-gjs');
+
+module.exports = {
+  ...base,
+  rules: gjsRules,
+};

lib/config-legacy/recommended-gts.js

@@ -0,0 +1,7 @@
+const base = require('./base');
+const gtsRules = require('../recommended-rules-gts');
+
+module.exports = {
+  ...base,
+  rules: gtsRules,
+};

lib/config-legacy/recommended.js

@@ -0,0 +1,7 @@
+const base = require('./base');
+const rules = require('../recommended-rules');
+
+module.exports = {
+  ...base,
+  rules,
+};

lib/config/base.js

@@ -1,27 +1,17 @@
-module.exports = {
-  root: true,
+const plugin = require('../index');
 
-  parserOptions: {
-    ecmaVersion: 2022,
-    sourceType: 'module',
+module.exports = [
+  {
+    plugins: { ember: plugin },
   },
 
-  env: {
-    browser: true,
-    es2022: true,
+  /**
+   * We don't want to *always* have the preprocessor active,
+   * it's only relevant on gjs and gts files to detect if eslint config is correctly setup for this files.
+   */
+  {
+    files: ['**/*.{gts,gjs}'],
+    parser: 'eslint-plugin-ember/gjs-gts-parser',
+    processor: 'ember/<noop>',
   },
-
-  plugins: ['ember'],
-
-  overrides: [
-    /**
-     * We don't want to *always* have the preprocessor active,
-     * it's only relevant on gjs and gts files to detect if eslint config is correctly setup for this files.
-     */
-    {
-      files: ['**/*.{gts,gjs}'],
-      parser: 'eslint-plugin-ember/gjs-gts-parser',
-      processor: 'ember/<noop>',
-    },
-  ],
-};
+];

lib/config/recommended-gjs.js

@@ -1,7 +1,4 @@
 const base = require('./base');
 const gjsRules = require('../recommended-rules-gjs');
 
-module.exports = {
-  ...base,
-  rules: gjsRules,
-};
+module.exports = [...base, { rules: gjsRules }];

lib/config/recommended-gts.js

@@ -1,7 +1,4 @@
 const base = require('./base');
 const gtsRules = require('../recommended-rules-gts');
 
-module.exports = {
-  ...base,
-  rules: gtsRules,
-};
+module.exports = [...base, { rules: gtsRules }];

lib/config/recommended.js

@@ -1,7 +1,4 @@
 const base = require('./base');
 const rules = require('../recommended-rules');
 
-module.exports = {
-  ...base,
-  rules,
-};
+module.exports = [...base, { rules }];

lib/index.js

@@ -2,10 +2,15 @@
 
 const requireIndex = require('requireindex');
 const noop = require('./preprocessors/noop');
+const pkg = require('../package.json'); // eslint-disable-line import/extensions
 
 module.exports = {
+  meta: {
+    name: pkg.name,
+    version: pkg.version,
+  },
   rules: requireIndex(`${__dirname}/rules`),
-  configs: requireIndex(`${__dirname}/config`),
+  configs: requireIndex(`${__dirname}/config-legacy`),
   utils: {
     ember: require('./utils/ember'),
   },

lib/rules/use-ember-data-rfc-395-imports.js

@@ -102,7 +102,11 @@ module.exports = {
           return;
         }
 
-        if (node.source.value === 'ember-data' || node.source.value.startsWith('ember-data/')) {
+        if (
+          node.source.value === 'ember-data' ||
+          (node.source.value.startsWith('ember-data/') &&
+            !node.source.value.startsWith('ember-data/types/registries/'))
+        ) {
           context.report({ node, message });
         }
       },

package.json

@@ -23,6 +23,7 @@
   "license": "MIT",
   "exports": {
     ".": "./lib/index.js",
+    "./configs/*": "./lib/config/*.js",
     "./gjs-gts-parser": "./lib/parsers/gjs-gts-parser.js"
   },
   "main": "./lib/index.js",

tests/lib/rules/use-ember-data-rfc-395-imports.js

@@ -40,6 +40,10 @@ ruleTester.run('use-ember-data-rfc-395-imports', rule, {
        name: SomethingRandom.DS('string')
      });
     `,
+    "import AdapterRegistry from 'ember-data/types/registries/adapter';",
+    "import ModelRegistry from 'ember-data/types/registries/model';",
+    "import SerializerRegistry from 'ember-data/types/registries/serializer';",
+    "import TransformRegistry from 'ember-data/types/registries/transform';",
   ],
 
   invalid: [

tests/plugin-exports.js

@@ -2,10 +2,10 @@
 
 const plugin = require('../lib');
 const ember = require('../lib/utils/ember');
-const base = require('../lib/config/base');
-const recommended = require('../lib/config/recommended');
-const recommendedGjs = require('../lib/config/recommended-gjs');
-const recommendedGts = require('../lib/config/recommended-gts');
+const base = require('../lib/config-legacy/base');
+const recommended = require('../lib/config-legacy/recommended');
+const recommendedGjs = require('../lib/config-legacy/recommended-gjs');
+const recommendedGts = require('../lib/config-legacy/recommended-gts');
 
 describe('plugin exports', () => {
   describe('utils', () => {