Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add plugin:@typescript-eslint/recommended to readme for GTS #2068

Merged
merged 1 commit into from
Jan 20, 2024

Conversation

evoactivity
Copy link
Contributor

GTS linting will not be correct without this plugin.

Should we also show the default node files override in the readme? So people don't blow those away when following the config recomendations.

@NullVoxPopuli
Copy link
Contributor

thank you!!

@NullVoxPopuli NullVoxPopuli merged commit 04355ff into ember-cli:master Jan 20, 2024
8 checks passed
@NullVoxPopuli
Copy link
Contributor

Should we also show the default node files override in the readme?

maybe, I think we can be a bit more terse with that config tho, like this:

{
  files: [
    '*.{js,cjs}',
    './config/**/*.js',
  ],
  extends: ['plugin:n/recommended'], // or whatever this was
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants