Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A failing test for no-deprecated-router-transition-methods (multiple classes) #2072

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

A failing test for no-deprecated-router-transition-methods (multiple classes) #2072

wants to merge 2 commits into from

Commits on Jan 24, 2024

  1. A failing test for no-deprecated-router-transition-methods 

    This rule incorrectly fails on the following code, where there is more than one Route class in a file:

```js
import Route from '@ember/routing/route';
import { action } from '@ember/object';

export class SettingsRoute extends Route {
  @action
  foo() {
    this.transitionTo('login');
  }
}

export class AnotherRoute extends Route {
  @action
  foo() {
    this.transitionTo('login');
  }
}
```
    @CvX
    CvX committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    7db63bb View commit details
    Browse the repository at this point in the history

  2. no-implicit-injections

    @CvX
    CvX committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    ac38eef View commit details
    Browse the repository at this point in the history