Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A failing test for no-deprecated-router-transition-methods (legacy class, decorators) #2073

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

A failing test for no-deprecated-router-transition-methods (legacy class, decorators) #2073

wants to merge 2 commits into from

Commits on Jan 24, 2024

  1. A failing test for no-deprecated-router-transition-methods (legacy cl… 

    …ass, decorators)

This rule incorrectly fails on the following code, where a legacy `.extend` class uses decorators:

```js
import Route from '@ember/routing/route';
import { action } from '@ember/object';

export default Route.extend({
  @action
  foo() {
    this.transitionTo('login');
  }
});
```
    @CvX
    CvX committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    1d6aa83 View commit details
    Browse the repository at this point in the history

  2. no-implicit-injections

    @CvX
    CvX committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    b30b1ba View commit details
    Browse the repository at this point in the history